[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] add the two command to add or delete the usb device instead of do it in QEMU console


  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "James (song wei)" <jsong@xxxxxxxxxx>
  • Date: Sun, 13 Dec 2009 18:41:12 -0800 (PST)
  • Delivery-date: Sun, 13 Dec 2009 18:41:31 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

 Yes, you are right. Sorry, I'll send the patch.

Pasi KÃrkkÃinen wrote:
> 
> On Tue, Oct 20, 2009 at 01:26:19AM -0600, James Song wrote:
>>    I rewrite the patch, pls check. I also put those as attachments.
>> 
>>    Thanks,
>>    -James
>> 
>>    Signed-off-by: James Song Wei <[1]jsong@xxxxxxxxxx>
>> 
>  
>>    diff -r 0705efd9c69e tools/python/xen/xend/server/SrvDomain.py
>>    --- a/tools/python/xen/xend/server/SrvDomain.py Fri Oct 16 09:04:53
>> 2009
>>    +0100
>>    +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Oct 19 10:15:06
>> 2009
>>    +0800
>>    @@ -225,6 +225,19 @@
>>             self.acceptCommand(req)
>>             return self.xd.domain_reset(self.dom.getName())
>> 
>>    +    def op_usb_add(self, op, req):
>>    +        self.acceptCommand(req)
>>    +        return req.threadRequest(self.do_usb_add, op, req)
>>    +
>>    +    def do_usb_add(self, _, req):
>>    +        return self.xd.domain_usb_add(self.dom.getName(), req)
>>    +
>>    +    def op_usb_del(self, op, req):
>>    +        self.acceptCommand(req)
>>    +        return req.threadRequest(self.do_usb_add, op, req)
>>    +
>>    +    def do_usb_del(self, _, req):
>>    +        return self.xd.domain_usb_add(self.dom.getName(), req)
>> 
> 
> Hello,
> 
> Shouldn't op_usb_del() use do_usb_del() and do_usb_del() use
> domain_usb_del() ?
> 
> Or did I miss something? 
> 
> -- Pasi
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 

-- 
View this message in context: 
http://old.nabble.com/add-the-two-command-to-add-or-delete-the-usb-device-instead-of-do-it-in-QEMU-console-tp25970825p26772284.html
Sent from the Xen - Dev mailing list archive at Nabble.com.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.