Re: [Xen-devel] [PATCH] Fix build failure in 32 environment

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 14/12/2009 16:52, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> It can be supported for existign features but not all new ones. We can
>> perhaps retire it all together after 4.0.
> 
> IMHO, this is not a new feature, this is an ABI incompatibility
> issue. If rdtscp is a valid 32-bit instruction, IMHO it
> should either work on both 32-bit Xen and 64-bit Xen or
> neither.

It only needs to work if we advertise RDTSCP in CPUID. Which we don't for
32-bit hosts. There's really nothing wrong with the patch that I can see.
I'd rather have the CPUID frobbing in xc_cpuid_x86.c, but it's a minor
concern. 

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel