Re: [Xen-devel] [PATCH] x86/mm: early put_page when XENMEM_add_to_physmap(XENMAPSPACE_gmfn)

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

> diff -r 07f98beddc18 xen/arch/x86/mm/shadow/common.c
> --- a/xen/arch/x86/mm/shadow/common.c Wed Dec 23 08:22:13 2009 +0000
> +++ b/xen/arch/x86/mm/shadow/common.c Thu Dec 24 14:07:04 2009 +0900
> @@ -2606,7 +2606,7 @@ int sh_remove_all_mappings(struct vcpu *
>      {
>          /* Don't complain if we're in HVM and there are some extra mappings: 
>           * The qemu helper process has an untyped mapping of this dom's RAM 
> -         * and the HVM restore program takes another. */
> +         * and the stub domain takes another. */
>          if ( !(shadow_mode_external(v->domain)
>                 && (page->count_info & PGC_count_mask) <= 3
>                 && (page->u.inuse.type_info & PGT_count_mask) == 0) )

This change is wrong - the stub domain _is_ the qemu helper process.
(The rest of the patch looks OK).

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel