[Xen-devel] Re: [PATCH] tmem: fix to 20945 "When tmem is enabled, reserve a fraction of memory"

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 17.02.10 13:10 >>>
>On 16/02/2010 18:30, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:
>
>> -    if ( opt_tmem && ((order == 0) || (order >= 9)) &&
>> -         (total_avail_pages <= midsize_alloc_zone_pages) )
>> -        goto fail;
>> +    if ( opt_tmem && (total_avail_pages <= midsize_alloc_zone_pages) )
>> +    {
>> +        if ( order == 0)
>> +            goto try_tmem;
>> +        if ( order >= 9)
>> +            goto fail;
>
>Why not try_tmem in the case that order>=9, too, rather than fail outright?

It could be done that way, but wouldn't have any effect, as tmem
doesn't even try to relinquish any memory when order > 0.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel