Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 25/02/2010 08:38, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> /* Now FACS... */
>> - if (fadt->header.revision >= FADT2_REVISION_ID)
>> + if (fadt->header.revision >= FADT2_REVISION_ID && fadt->facs == 0)
>> facs_pa = fadt->Xfacs;
>> else
>> facs_pa = (uint64_t)fadt->facs;
> 
> Wouldn't that generally suppress using fadt->Xfacs, since I think in
> order to be pre-2.0-OS compatible a BIOS would not normally set
> facs to zero when Xfacs is non-zero? Or is that a requirement by the
> spec?

Good question would be: What does Linux do here?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel