[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] linux/blkfront: fixes for 'xm block-detach ... --force'



>>> Daniel Stodden <daniel.stodden@xxxxxxxxxx> 26.02.10 22:50 >>>
>I think this one resulted in blkfront_remove (from xenbus) racing
>against blkif_release (run from close(bdev)). 
>
>Both running for their respective kfree(info) vs. subsequent
>dereferences. Or just to leak info entirely.
>
>We only had blkfront_closing() on either thread before, which serializes
>around the bd_mutex.
>
>I'm currently thinking that info now rather wants a refcount of its own.
>Ideally replacing is_ready entirely, maybe.
>
>Any thoughts?

Could you check the fixup patch I sent just a couple of minutes
ago (paralleling c/s 993 on the 2.6.18 tree)?

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.