RE: [Xen-devel] Re: [PATCH] Qemu: Add sanity check for vcpu config

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Yes, I know :)
I just speaking out my thinking.

Thanks,
Jinsong

Keir Fraser wrote:
> I'm not dead against a sanity check in qemu.
> 
>  -- Keir
> 
> On 23/03/2010 02:17, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> 
>> Keir,
>> 
>> Have you decided where should vcpu sanity check be located?
>> We add vcpu sanity check at qemu because:
>> 1. xen/qemu itself has knowledge like HVM_MAX_VCPUS, xend doesn't
>> have such knowledge; 
>> 2. there are many ways to transfer config/cmdline para to qemu,
>> xm/xend is one of them which used at Xen. On other system like KVM,
>> there is no xm/xend at all. So naturely qemu is a better place to do
>> sanity check than xend; 
>> 3. even if we add sanity check at xend, qemu still need do sanity
>> check. After all, qemu cannot totally trust its input;
>> 
>> Thanks,
>> Jinsong
>> 
>> Ian Jackson wrote:
>>> Keir Fraser writes ("[Xen-devel] Re: [PATCH] Qemu: Add sanity check
>>> for vcpu config"):
>>>> Wouldn't xend be a more sensible place to do the check? It can
>>>> certainly result in a better error message, I would have thought.
>>> 
>>> Quite so.  If you add feature to xend, it should be changed in
>>> libxl too. 
>>> 
>>> Ian.
>>> 
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>>> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel