[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity


  • To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • From: Dulloor <dulloor@xxxxxxxxx>
  • Date: Tue, 23 Mar 2010 12:40:18 -0400
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
  • Delivery-date: Tue, 23 Mar 2010 09:41:13 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=X6TmQQnuJNrUVJbUQVKaNleJkxu0JFMVrcbleyP9aY0xgLkh8RTLrlJ3XjsDsZEb7r ohLDJJuGtthbA4oFrsSFPJWOuLqU6UVis3XRU26QCf6spYYqz1pGApCWdx5yTdV1GTl6 Hccdx24bue7w9HFaa+7dskJK2U6Fg8zn7v+RE=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Fine, I agree with you both. Attached is a patch adding utils for
xenctl_bitmap (to libxc) and using the same in vcpu_(get|set)affinity.
For the guest-numa interface, I will see if I can use xenctl_cpumap.

-dulloor

On Tue, Mar 23, 2010 at 7:05 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> On 23/03/2010 10:10, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>
>>>>> Dulloor <dulloor@xxxxxxxxx> 22.03.10 18:44 >>>
>>> Motivation for using xenctl_cpumask in Xen interfaces :
>>> - xenctl_cpumap is just 4 bytes smaller than static xenctl_cpumask for
>>> 128 cpus (128 would be good for quite some time). However, the new
>>
>> I don't buy this (we're already building for 256 CPUs, looking forward
>> to further bump this in the not too distant future), and I'm generally
>> opposed to introducing hard coded limits in a public interface.
>
> We should use xenctl_cpumask everywhere for specifying physical CPU bitmaps,
> even into guest NUMA interfaces if appropriate. I don't really care if it is
> a bit harder to use than a static bitmap.
>
>  -- Keir
>
>
>

Attachment: cpumap-utils.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.