[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] continue_hypercall_on_cpu rework using tasklets


  • To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Wed, 14 Apr 2010 09:25:25 +0200
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 14 Apr 2010 00:26:09 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:Content-Type: Content-Transfer-Encoding; b=oqQnOpBsFdplrXWyNRdM47bCXjMsDbb6RZ1LV2MR+vEb+JYR9b3/2AxE 0qn6TrUuWd91C3ww2HWEiKQuTf4dIq6tpcIruDsWkNKeoSrP2hbEXZu3x 1SvzfcUdNh3U+XqgcnNTqBLhzRecaVPn5csm5ZIQGEpXB//uFGmEUXENp 2m+2bisyNVzs+uxd83QXjV9TvxVVv2/eaFuRnWsK9QpHuegfRCKRBU9zv 39LHPsf3g+K/PiQxKrm+2GjQtEYmA;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Keir Fraser wrote:
> On 14/04/2010 07:58, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:
> 
>>> The per-cpu area method should work fine, since Xen is non-preemptive? I
>>> don't think the concurrency you are concerned about can happen.
>> The tasklet knows only on which cpu it is running, so the data has to be
>> stored on the target cpu. And one pcpu can be the target of concurrent calls
>> from different calling cpus...
> 
> A tasklet also takes an arbitrary ulong parameter, which you can cast to a
> pointer to your informational structure. The parameter is specified via
> tasklet_init(). That should suffice.

I'm already using this. The problem is to find the original calling vcpu in
case of a nested call of continue_hypercall_on_cpu() while not conflicting
with concurrent calls from other vcpus which happen to address the same pcpu.


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.