Re: [Xen-devel] [PATCH] libfsimage: zfs build fix

[Mark Johnson <johnson.nh@xxxxxxxxx>]

On Thu, Apr 15, 2010 at 10:10 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libfsimage: zfs build fix"):
>> Attached patch makes libfsimage build again on NetBSD.

The fsimage zfs patch was changed around to make it simpler
to keep in sync with the grub changes.  fsys_zfs.c, etc are exact copies
of what's in grub  e.g.
    
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/grub/grub-0.97/stage2/fsys_zfs.c

fsi_zfs.* are kludges to get the grub code to fit into libfsimage and
is the only code which is different from the grub code.

It would be easier to keep in sync if this would be continued.


>> uchar_t is not defined because both FSYS_ZFS and FSIMAGE
>> are defined at build time.

for this, I would suggest extending this in fsi_zfs.h

#ifdef  __linux__
typedef unsigned char   uchar_t;
#endif



>> Also fix warnings with ctype.
>
> The ctype problems are more than warnings - they would give undefined
> behaviour if high-bit-set characters are passed.

I didn't write that code and agree that it's pretty ugly :-).
I assume you talking about where the char is sign extended
or not? Just curious, what's the case that isspace() gives
a wrong answer here?




MRJ




>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel