Re: [Xen-devel] [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix

[Jim Fehlig <jfehlig@xxxxxxxxxx>]

Jan Beulich wrote:
>>>> Jim Fehlig <jfehlig@xxxxxxxxxx> 16.04.10 22:51 >>>
>>>>         
>> Jan Beulich wrote:
>>     
>>> Perhaps this should even be further generalized (e.g. to remove any
>>> "[!/]*:" pattern prefixes) to be more forward compatible?
>>>   
>>>       
>> Right.  Need to handle the 'ioemu' subtype as well.  How about just
>> stripping of everything before the leading '/'?  E.g. like the attached
>> patch?
>>     
>
> Wouldn't that become wrong when remote locations are acceptable
> here (not sure if they aren't already), i.e. server:/path/file? 

IMO, remote locations should be handled by another tap driver optimized
for the remote file protocol, similar to the nbd, curl, etc. block
backends in qemu.

> If that
> is not expected to ever have a meaning and if relative paths aren't
> permitted here, then yes, that would of course be the best solution.
>   

The tools currently don't cope with relative paths in disk specification.

Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel