[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table

To: <dongxiao.xu@xxxxxxxxx>,<xen-devel@xxxxxxxxxxxxxxxxxxx>
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 22 Apr 2010 08:18:49 +0100
Cc:
Delivery-date: Thu, 22 Apr 2010 00:19:52 -0700
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

>>> "Xu, Dongxiao"  04/22/10 4:42 AM >>>
The use of map_domain_page() here is lacking a respective
unmap_domain_page() on all possible paths.

Further, assuming the amount of information printed may be
huge, there ought to be calls to process_pending_softirqs()
to keep time management from getting screwed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

Follow-Ups:
- Re: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table
  - From: Tim Deegan

Prev by Date: [Xen-devel] harddisk offline frequently when running vm
Next by Date: [Xen-devel] Re: [PATCH] CPUIDLE: shorten hpet spin_lock holding time
Previous by thread: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table
Next by thread: Re: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.