Re: [Xen-devel] [PATCH 6 of 6] PV on HVM suspend\resume

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

On 04/22/2010 08:17 AM, Stefano Stabellini wrote:
> +static void do_hvm_suspend(void)
> +{
> +     int err;
> +     int cancelled = 1;
> +
> +     shutting_down = SHUTDOWN_SUSPEND;
> +
> +     err = stop_machine_create();
> +     if (err) {
> +             printk(KERN_ERR "xen suspend: failed to setup stop_machine 
> %d\n", err);
> +             goto out;
> +     }
> +
> +#ifdef CONFIG_PREEMPT
> +     /* If the kernel is preemptible, we need to freeze all the processes
> +        to prevent them from being in the middle of a pagetable update
> +        during suspend. */
> +     err = freeze_processes();
> +     if (err) {
> +             printk(KERN_ERR "xen suspend: freeze failed %d\n", err);
> +             goto out_destroy_sm;
>   

This won't compile with CONFIG_PREEMPT enabled, because out_destroy_sm
is missing below.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel