Re: [Xen-devel] [PATCH] xl: support specifing '[vars]' in 'xl create'

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 28 Apr 2010, Yu Zhiguo wrote:
> 
> Add support of specifing '[vars]' in 'xl create'.
> It is said '[vars]' can be used in help message of 'xl create',
> but in fact cannot now, so add this function.
> 
> After this fix:
> # xl create pvguest1.conf
> # xl list
> Name                                        ID   Mem VCPUs      State   
> Time(s)
> Domain-0                                     0  1024     2        r--    161.0
> pvguest1                                    29   256     2        r--      0.5
> # xl destroy pvguest1
> # xl create pvguest1.conf vcpus=4 memory=512 'name="pv1"'
> # xl list
> Name                                        ID   Mem VCPUs      State   
> Time(s)
> Domain-0                                     0  1024     2        r--    162.2
> pv1                                         30   512     4        r--      0.2
> 
> Signed-off-by: Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>
> 
> diff -r c87ec146229a -r 51bb2db1ed51 tools/libxl/xl.c
> --- a/tools/libxl/xl.c        Fri Apr 23 15:04:26 2010 +0100
> +++ b/tools/libxl/xl.c        Thu Apr 29 00:02:02 2010 +0800
> @@ -777,7 +777,9 @@
>      return r;
>  }
>  
> -static int create_domain(int debug, int daemonize, const char *config_file, 
> const char *restore_file, int paused, int migrate_fd /* -1 means none */, 
> char **migration_domname_r)
> +static int create_domain(int debug, int daemonize, const char *config_file, 
> const char *restore_file,
> +                         int paused, int migrate_fd /* -1 means none */, 
> char **migration_domname_r,
> +                         const char *extra_config)

This line is misaligned.
Also, I feel that create_domain's arguments are growing too much, it would
be a good idea to reorganize them in a struct.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel