Re: [Xen-devel] Re: [PATCH] Add hypercall to mark superpages to improve performance

[Dave McCracken <dcm@xxxxxxxx>]

On Sunday 02 May 2010, Keir Fraser wrote:
> Oh, now I think about it, although your suggestion deals with type
> conflicts, it doesn't handle page lifetimes. What if a page is only mapped
> as a superpage? The page->count_info would not be incremented by the
> superpage mappings, and the page would be erroneously freed to the Xen free
> pools? So I'm not so sure we can so easily avoid the
> mess-with-every-page's-refcount on first mapping of a superpage... :-(

It should be simple enough to also check superpage->count_info in those 
places.  So the total mappings of a page would be page->count_info + 
superpage->count_info.  Good thing you suggested we also have a count in the 
superpage_info struct :)

Dave

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel