[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3/3]xl: Add command description to command table
Yang Hongyang writes ("[Xen-devel] [PATCH 3/3]xl: Add command description to command table"): > Add command description to command table Thanks. I see this has already been applied. However: > diff -r b695c51b8345 -r 25e930534a5d tools/libxl/xl.c > --- a/tools/libxl/xl.c Thu Apr 29 23:07:31 2010 +0800 > +++ b/tools/libxl/xl.c Fri Apr 30 00:16:19 2010 +0800 > @@ -31,6 +31,9 @@ > #include "xl_cmdimpl.h" > #include "xl_cmdtable.h" > > +extern struct cmd_spec cmd_table[]; > +extern int cmdtable_len; > + > extern struct libxl_ctx ctx; > extern int logfile; This is wrong. Use of "extern" in this way in a .c file is incorrect; pure predeclarations should appear only in .h files, and they should appear exactly once each. That way they can't get out of step. I'll send a patch to fix this at some point. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |