Re: [Xen-devel] [PATCH 3/3]xl: Add command description to command table

[Yang Hongyang <yanghy@xxxxxxxxxxxxxx>]

Hi Keir,

On 05/05/2010 12:20 AM, Keir Fraser wrote:
> On 04/05/2010 17:10, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> 
>>> +extern struct cmd_spec cmd_table[];
>>> +extern int cmdtable_len;
>>> +
>>>  extern struct libxl_ctx ctx;
>>>  extern int logfile;
>>
>> This is wrong.  Use of "extern" in this way in a .c file is incorrect;
>> pure predeclarations should appear only in .h files, and they should
>> appear exactly once each.  That way they can't get out of step.
>>
>> I'll send a patch to fix this at some point.
> 
> I fixed it before I applied it.

Thank you for that!

> 
>  -- Keir
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 


-- 
Regards
Yang Hongyang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel