RE: [Xen-devel] RE: [PATCH] x86: add CMCI software injection interface

["Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>]

>-----Original Message-----
>From: Frank Van Der Linden [mailto:frank.van.der.linden@xxxxxxxxxx]
>Sent: Wednesday, May 05, 2010 11:52 AM
>To: Ke, Liping
>Cc: Keir Fraser; Jiang, Yunhong; gavin.maltby@xxxxxxxxxx; Egger;
>xen-devel@xxxxxxxxxxxxxxxxxxx; Christoph@xxxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel] RE: [PATCH] x86: add CMCI software injection interface
>
>On 5/4/10 7:56 PM, Ke, Liping wrote:
>> Hi, Keir
>>
>> Yes, we do some discussion about the interface compatibility problem before
>submitting.
>> But we found the mceinj_cpunr below is defined as unsigned int (not uint32), 
>> so we
>think it may have some problem in 32/64 bit machine originally.
>> So we gave up the backward compatibility effort and made it as uint32_5. But 
>> if
>sun/oracle use this interface before, we did have some problem
>>
>> So Christopher and Gavin, any suggestions for this?
>>
>> Regards,
>> criping
>
>I have no problems with this change. dom0/Xen should match in version
>anyway. There have been ABI breakages in the dom0/Xen interface before.
>You can bump the xen MCE hypercall version if you wish..

Maybe another method is to add a new do_mca command for the CMCI, like 
#define XEN_MC_cmci_inject    6

Of course, we can update the interface version, to make the new command will 
only be supported in new version. So that when new dom0 will not get 
un-expected result when running in old xen hypervisor.
Any idea?

Thanks
--jyh

>
>- Frank

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel