[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] reap the blktapctl thread and notify the tapdisk backend driver to release resource like memory..



James Song writes ("[Xen-devel] [PATCH 2/2] reap the blktapctl thread and 
notify the tapdisk backend driver to release resource like memory.."):
> I write a new patch for this issue, which modified qemu code.  So
> Ian, could you take a look this patch,too.

As far as I can see the effect here is to catch SIGINT in order to do
some kind of cleanup.  I don't think that is right.  qemu could quite
easily crash (and does!) so it is not right for cleanup to happen in
qemu.

If there is any cleanup that needs doing it needs to be done by qemu's
caller.

Reading the message you refer to, surely it should be the job of the
toolstack (xend or libxl) to ensure that the backends are instructed
to do all necessary releasing ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.