Re: [Xen-devel] [PATCH] vncpassword support in libxl

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] vncpassword support in 
libxl"):
> The indentation is often wrong and sometimes you are adding\removing
> blank lines for no reason.
> But apart from this small cosmetic issues the patch looks good.

You missed that he removed this line:

-    printf("Parsing config file %s\n", config_file);

This demonstrates why patches with spurious stuff in should be
rejected - it's too easy to miss a mistake when scanning past a lot of
spurious changes.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel