RE: [Xen-devel][PATCH] dom0 vcpu set problem

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Dietmar Hahn wrote:
> Am 11.05.2010 schrieb Jan Beulich:
>>>>> Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx> 11.05.10 08:19 >>>
>>> Can anybody point me where in the code the acpi cpu hotplug gets
>>> triggered to add the vcpu again to the dom0 kernel after setting
>>> the xenstore! 
>> 
>> No, ACPI hotplug code is not involved in pv domains' vCPU adding or
>> removal. Instead, the pv kernels create a xenstore watch on their
>> domain's "cpu" node, reading cpu/<id>/availability when the watch
>> fires. See drivers/xen/core/cpu_hotplug.c (for the forward ported
>> kernels) or drivers/xen/cpu_hotplug.c (for the pv-ops ones).
>> 
>> Jan
> 
> It's the pv-ops kernel from within the xen-4.0-testing.hg tree.
> Thanks, Jan ;-)
> Pointing to the right place I found a missing cpu_up() call
> in the vcpu_hotplug() function.
> Now all my vcpus are back again on my machine ;-)
> Thanks.
> 
> Dietmar.
> 
> 
> Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> 
> diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
> index bdfd584..f3f0c1e 100644
> --- a/drivers/xen/cpu_hotplug.c
> +++ b/drivers/xen/cpu_hotplug.c
> @@ -49,6 +49,7 @@ static void vcpu_hotplug(unsigned int cpu)
>         switch (vcpu_online(cpu)) {
>         case 1:
>                 enable_hotplug_cpu(cpu);
> +               (void)cpu_up(cpu);
>                 break;
>         case 0:
>                 (void)cpu_down(cpu);

No, I don't think you need update pv-ops kernel so.
vcpu-add just set it to cpu present map, not online map.
It provide user chance to echo 1 > /sys/devices/system/cpux/online to make cpu 
work (means, to add cpu to online map).

The original pv-ops vcpu hotplug logic is right.

Thanks,
Jinosng
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel