Re: [Xen-devel] [PATCH] x86-32: use __builtin_{memcpy,memset}

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 11/05/2010 11:39, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> Hm, well, I hate having to change this stuff as we always seem to end up
> broken on some gcc or other. But otoh this will eliminate a bunch of code if
> we do this unconditionally, and I'm particularly not keen on doing this only
> for x86-32 and particular versions of gcc. I suggest the attached patch: it
> should work fine so long as all our supported versions of gcc have
> __builtin_memcpy and __builtin_memset. Given we nowadays only support GCC
> 3.4+, I imagine we are okay in this regard.
> 
> What do you think to this alternative patch?

Jan,

What about this alternative version which distinguishes between GCC 4.3+
(which should auto-inline quite sensibly) and earlier versions (which need
help via macro mapping explicitly to __builtin_*)?

 -- Keir

Attachment: 00-string
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel