Re: [Xen-devel] [PATCH 0/2] xl: Add subcommand mem-max and fix mem-set

[Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>]

Yu Zhiguo wrote:
> Yu Zhiguo wrote:
>> I'm trying to add subcommand 'mem-max', I think xc_domain_setmaxmem should
>> be used in it but not here.
>>
>> I'll move this code to 'mem-max', and in 'mem-set', a check should be added
>> because setting memory larger than max memory is invalid.
>>
>> 1. Add 'mem-max'
>>   Add libxl_domain_setmaxmem, it calls xc_domain_setmaxmem.
>>   /local/domain/$domid/memory/static-max should be updated when set max 
>> memory,
>> it is missing now.
>>
>> 2. fix 'mem-set'
>>   Delete xc_domain_setmaxmem.
>>   Get max memory from /local/domain/$domid/memory/static-max, and then do 
>> value check.
>> It seems that we cannot get max memory use libxc routines.
>>
> 
> I fixed it, please check.
> 
> [PATCH 1/2] xl: Add command 'xl mem-max'
> [PATCH 2/2] xl: Add check for command 'xl mem-set'
> 

It seems than /local/domain/$domid/memory/target cannot be created when use 'xl 
create',
only /local/domain/0/memory/static-max is existent.
Isn't it a bug? I'll check the code.

I think it should be created like static-max.
* memory/target can be created when use 'xm create'


> 
> Regards
> Yu Zhiguo
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 
> 


-- 
Regards
Yu Zhiguo
--------------------------------------------------
Yu Zhiguo
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
8/F., Civil Defense Building, No.189 Guangzhou Road,
Nanjing, 210029, China
TEL: +86+25-86630566-853
COINS: 79955-853
FAX: +86+25-83317685
MAIL: yuzg@xxxxxxxxxxxxxx
--------------------------------------------------
This communication is for use by the intended recipient(s) only and may contain 
information that is privileged, confidential and exempt from disclosure under 
applicable law. If you are not an intended recipient of this communication, you 
are hereby notified that any dissemination, distribution or copying hereof is 
strictly prohibited.  If you have received this communication in error, please 
notify me by reply e-mail, permanently delete this communication from your 
system, and destroy any hard copies you may have printed.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel