Re: [Xen-devel] [PATCH] ocaml: fix ocaml xc compilation on 32 bit

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2010-05-20 at 13:24 +0100, Christoph Egger wrote:
> On Thursday 20 May 2010 14:13:06 Ian Campbell wrote:

> > -   c_array = malloc(sizeof(xen_pfn_t) * c_nr_pfns);
> > +   c_array = malloc(sizeof(uint64_t) * c_nr_pfns);
> 
> Wouldn't it be better to have here
> 
> +     c_array = calloc(c_nr_pfns, sizeof(uint64_t));

I suppose so but that would be an unrelated change, please post a patch
if you think it is worth it.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel