[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2]xl: Add "xl top" command

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 21 May 2010 11:29:06 +0100
Delivery-date: Fri, 21 May 2010 03:29:56 -0700
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Yang Hongyang writes ("[Xen-devel] [PATCH 2/2]xl: Add "xl top" command"):
> Add "xl top" command, a clone of "xm top".
> 
> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>

This is mostly OK, but:

> +    system("xentop");

1. You should probably use execlp rather than system.
2. You do not check the return value.  This is a serious mistake.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

References:
- [Xen-devel] [PATCH 2/2]xl: Add "xl top" command
  - From: Yang Hongyang

Prev by Date: Re: [Xen-devel] [PATCH 15/17] vmx: nest: virtual ept for nested
Next by Date: Re: [Xen-devel] [PATCH 08/17] vmx: nest: L1 <-> L2 context switch
Previous by thread: [Xen-devel] [PATCH 2/2]xl: Add "xl top" command
Next by thread: RE: [Xen-devel] XCP: source repo?
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.