[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Re: blktap2 problem with pvops kernel 2.6.32.13 and xen 4.0-rc1


  • To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • From: eXeC001er <execooler@xxxxxxxxx>
  • Date: Sun, 30 May 2010 16:21:30 +0400
  • Cc: Boris Derzhavets <bderzhavets@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Sun, 30 May 2010 05:22:25 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=UQ2pprSABcAJjHEY4YDXDtkv47fcWaRC+4xG0+FHHFE2kaaXySBiEljMp/30KC+RzM W4nhLijsqIRbJdfstTssEs8oisMVVM2kt8npbf3Rye7Vi3YE7X0wCkcE75lHOHXBbKey K27zoKPMEBW2gguufppWAWiLYnH3hF51U2VE0=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

My python-experienceÂis small, but i tied to rewrite.
New in attach.

2010/5/30 Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
On 30/05/2010 11:37, "Pasi KÃrkkÃinen" <pasik@xxxxxx> wrote:

> On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote:
>> Â ÂI have already sent a patch 1 weak ago. (blktap2_control_func.patch)
>> Â Ârepeat in attach.
>> Â ÂThanks.
>
> Ok, thanks.
>
> Keir: I guess this is not committed yet?

I'm not too happy about the sleep(5). I guess if there's no better solution
coming up I should just whack this patch in?

Â-- Keir

> -- Pasi
>
>> Â Â2010/5/30 Pasi KÃrkkÃinen <[1]pasik@xxxxxx>
>>
>> Â Â ÂOn Sun, May 30, 2010 at 11:17:51AM +0400, eXeC001er wrote:
>>> Â Â ÂI've attempted to install Nexenta Core 3 image under Xen 4.0
>> Â Â Â(2.6.32.13
>>> Â Â Âpvops) on top of F13. Sample nexenta3.cfg profile contains 4
>> Â Â Âlines like
>>> Â Â Âthis:-
>>>
>>> Â Â Âdisk=['tat:tapdisk:vhd:/path/../disk.img,xvda,w'] ( from sample)
>>>
>>> Â Â ÂIt generates message
>>> Â Â ÂÃ File 'vhd:/path/.../disk.img' doesn't exist.
>>>
>>> Â Â ÂBoris.
>>> Â Â ÂP.S. It was already in one of the threads @xen-users.
>>>
>>> Â ÂThis bug in "def _parse_uname(uname):"
>> Â Â Â(tools/python/xen/util/blkif.py)
>>> Â Â(taptype, fn) = fn.split(":", 1) >>>>>>Ã (taptype, fn) =
>> Â Â Âfn.split(":",
>>> Â Â2)[1:3]
>>
>> Â Â ÂCan you send a proper patch, as unified diff (diff -u), with a
>> Â Â ÂSigned-off-by line?
>> Â Â Â-- Pasi
>>
>> References
>>
>> Â ÂVisible links
>> Â Â1. mailto:pasik@xxxxxx
>
>> diff -r d0420ab97345 tools/python/xen/util/blkif.py
>> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2010 +0100
>> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2010 +0400
>> @@ -87,7 +87,7 @@
>> Â Â Â Â Â Â Â Â Âfn = "/dev/%s" %(fn,)
>>
>> Â Â Â Â Âif typ in ("tap", "tap2"):
>> - Â Â Â Â Â Â(taptype, fn) = fn.split(":", 1)
>> + Â Â Â Â Â Â(taptype, fn) = fn.split(":", 2)[1:]
>> Â Â Âreturn (fn, taptype)
>>
>> Âdef blkdev_uname_to_file(uname):
>> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.py
>> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 16:21:39 2010 +0100
>> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 01:21:15 2010 +0400
>> @@ -3292,6 +3292,7 @@
>> Â Â Â Â Â Â Â Â Âfn = BOOTLOADER_LOOPBACK_DEVICE
>>
>> Â Â Â Â Â Â Âtry:
>> + Â Â Â Â Â Â Â Âtime.sleep(5)
>> Â Â Â Â Â Â Â Â Âblcfg = bootloader(blexec, fn, self, False,
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â bootloader_args, kernel, ramdisk, args)
>> Â Â Â Â Â Â Âfinally:
>> @@ -3299,7 +3300,7 @@
>> Â Â Â Â Â Â Â Â Â Â Âlog.info("Unmounting %s from %s." %
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (fn, BOOTLOADER_LOOPBACK_DEVICE))
>>
>> - Â Â Â Â Â Â Â Â Â Âdom0.destroyDevice('tap', BOOTLOADER_LOOPBACK_DEVICE)
>> + Â Â Â Â Â Â Â Â Â Âdom0.destroyDevice(devtype, BOOTLOADER_LOOPBACK_DEVICE)
>>
>> Â Â Â Â Â Â Âif blcfg is None:
>> Â Â Â Â Â Â Â Â Âmsg = "Had a bootloader specified, but can't find disk"
>



Attachment: bltap2_control_func.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.