Re: [Xen-devel] [PATCH] xc: deal with xen/evtchn and xen/gntdev device names

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2010-05-29 at 02:08 +0100, Jeremy Fitzhardinge wrote:
> This patch makes xc_linux properly deal with:
>  1. discovering and creating device nodes if necessary
>  2. the new form of xen/<dev> device names soon to be used by the kernel
> 
> This changes the logic slightly:
>  - If a device node already exists with the proper name, then it uses it
>    as-is, assuming it has already been correctly created.
>  - If the path doesn't exist, or it exists but isn't a device node, and
>    it has successfully found the major/minor for the device, then
>    (re)create the device node.
> 
> Since this logic is identical for gntdev and evtchn, make a common function
> to handle both.

Does any of this logic really belong in libxc in the first place? 

Can we not just rip it all out and make it the distro/platform's
responsibility to ensure these devices exist and are correct? Perhaps
that might involve shipping some default/example udev rules instead.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel