Re: [Xen-devel] syslog support to xentoollog

[Gihan Munasinghe <GMunasinghe@xxxxxxxxxxxx>]

Stefano Stabellini wrote:
> On Wed, 2 Jun 2010, Gihan Munasinghe wrote:
>   
> > Guys
> >
> > Is there any plans to add syslog support in to xentoollog.
> >
> > Is this something that xentoollog would like to adopt .
> >
> >     
> That is something we definitely want, patches are welcome :-)
>
>   
Great I'll do some patching to get syslog working.

looking at the xentool.h, following definitions

#define XTL_STDIOSTREAM_SHOW_PID      01u
#define XTL_STDIOSTREAM_SHOW_DATE     02u
#define XTL_STDIOSTREAM_HIDE_PROGRESS 04u

I would suggest to be as
#define XTL_SHOW_PID      01u
#define XTL_SHOW_DATE     02u
#define XTL_HIDE_PROGRESS 04u
So it will be more generic for any loggers that will be implemented

also is everyone happy with following loglevel mappings between 
xentoollog_level and syslog
       {XTL_DEBUG,LOG_DEBUG},
       {XTL_VERBOSE,LOG_DEBUG},
       {XTL_DETAIL,LOG_DEBUG},
       {XTL_PROGRESS,LOG_DEBUG},
       {XTL_INFO,LOG_INFO},
       {XTL_NOTICE,LOG_NOTICE},
       {XTL_WARN,LOG_WARNING},
       {XTL_ERROR,LOG_ERR},
       {XTL_CRITICAL,LOG_CRIT}

Thanks
Gihan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel