Re: [Xen-devel] [PATCH] add xl init scripts

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 4 Jun 2010, Stefano Stabellini wrote:
> > Is a network script really required for xl? I think it would be more in
> > keeping with how xl works to require that the distro configuration be
> > setup correctly to create bridges etc e.g. correctly
> > setup /etc/network/interfaces under Debian
> > or /etc/sysconfig/network-scripts/ifcfg-* under RH derived distros etc.
> > 
> > Similarly I think xl should assume that the platform has been correctly
> > configured with a vif hotplug script with the correct behaviour? It's
> > not clear to me why tools/hotplug/Linux/xen-backend.rules needs to use a
> > different scheme for vif devices to all the other backend types. The
> > script there could be a symlink to one of several variants if necessary,
> > there's no reason for it to be a config item in xl (or xend for that
> > matter)
> > 
> > It seems like we are now replicating some of the worst bits of xend
> > poking around behind the back of the distro config files in xl.
> > 
> 
> I think using the distro settings is definitely better, in fact you can
> set whatever network script you want (including nothing), in the
> NETWORK_SCRIPT variable, maybe NETWORK_SCRIPT= could be the default.
> 
> However network-bridge is quite handy and simple to use, I think we
> should provide the users a simple way to automatically setup the network
> no matter what their distro is.
> 

Expanding on the xen-backend.rules subject, I guess the advantage of the
current strategy is that it allows users to configure each vif of each
VM differently, whether they want them in routed or bridged mode or even
other possible configurations we don't know about. If we hardcode the
script name in xen-backend.rules then it would become a global platform
configuration and not a per-vif configuration anymore.
If we decide that we don't care about it, then we can use a symlink or a
simple script that changes behavior depending on a sysconfig variable,
like you said.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel