[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [Linux PATCH] Mark hugepages to the hypervisor to speed up mapping (with signoff this time)


  • To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
  • From: Dave McCracken <dcm@xxxxxxxx>
  • Date: Wed, 9 Jun 2010 13:20:33 -0500
  • Cc: Xen Developers List <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 09 Jun 2010 11:21:25 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On Wednesday, June 09, 2010, Jeremy Fitzhardinge wrote:
> > +             return 1;
> > +     }
> > +     for (i = 0, m = mfn; i < HPAGE_SIZE/PAGE_SIZE; i++, pfn++, m++) {
> > +             if (pfn_to_mfn(pfn) != m) {
> > +                     printk("Guest pages are not properly aligned to use
> > hugepages\n");
> >
> >   
> 
> Isn't this a superset of the previous test?

The code is doublechecking to make sure this hugepage is actually contiguous 
at the machine level.

Dave McCracken
Oracle Corp.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.