Re: [Xen-devel] [PATCH 4 of 4] libxl: Use libblktapctl.so

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 10 Jun 2010, Daniel Stodden wrote:
> I don't quite manage to follow this comment. The behavior was meant to
> match the original version of that code. It still looks like it does. Is
> that what you question?
> 
> Unless you're worried about null pointer handling with massively broken
> compilers? Did you ever manage to find one? I didn't %-)
> 
> But again, if you're not happy with it, please just go ahead and make it
> suit your coding preferences. I got zero stakes in that code. 
> 

Nope, you are right, after a second look the code seems correct.
However it still doesn't work for me.
The device returned by make_blktap2_device is /dev/xen/blktap-2/tapdev0,
but "cat /sys/class/blktap2/devices" returns nothing and my VM doesn't
start.
Am I missing something?

> Btw, someone probably should also fix the device teardown path as well,
> it seems to be consistently leaking device nodes. I guess enumerating
> backend physical-device nodes to count vbds would probably do for a
> 'light' control layer.
> 

you are right, are you volunteering ? ;-)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel