Re: [Xen-devel] [PATCH] apic: clean up msr handling

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 11.06.10 at 15:22, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
>-static inline void write_efer(u64 val)
>-{
>-    this_cpu(efer) = val;
>-    wrmsrl(MSR_EFER, val);
>-}
>+#define write_efer(val) do { \
>+    this_cpu(efer) = val; \
>+    wrmsrl(MSR_EFER, val); \
>+} while(0)

This isn't a good change imo: You now require all current and future
users of write_efer() to not pass expressions with side effects.

Also, is doesn't really look like a cleanup to me, more like a
complication.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel