Re: [Xen-devel] [PATCH 12/12] Unplug emulated disks and nics

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 17 Jun 2010, Konrad Rzeszutek Wilk wrote:
> If was thinking of something like this in the header file:
> 
> 
> int xen_must_unplug_nics() {
> #if (defined(CONFIG_XEN_NETDEV_FRONTEND) || \
>               defined(CONFIG_XEN_NETDEV_FRONTEND_MODULE)) && \
>               (defined(CONFIG_XEN_PLATFORM_PCI) || \
>                defined(CONFIG_XEN_PLATFORM_PCI_MODULE))
>       return 1;
> #else
>       return 0;
> }
> 
> and then your code would be:
> 
>       if (xen_must_unplug_nics()) {
>               printk(".. blah blah ");
>               xen_emul_unplug |- XEN_unPLIG_ALL_NICS;
>       }
> 
> and similar for the IDE disks.
> 

this seems actually better, I'll do that

> > 
> > 
> > > > +       }
> > > > +       /* Now unplug the emulated devices */
> > > > +       if (xen_platform_pci_enabled && !(xen_emul_unplug & 
> > > > XEN_UNPLUG_IGNORE))
> > > > +               outw(xen_emul_unplug, XEN_IOPORT_UNPLUG);
> > > > +}
> > > > +
> > > > +static int __init parse_xen_emul_unplug(char *arg)
> > > > +{
> > > > +       char *p, *q;
> > > > +
> > > > +       for (p = arg; p; p = q) {
> > > > +               q = strchr(arg, ',');
> > > > +               if (q)
> > > > +                       *q++ = '\0';
> > > > +               if (!strcmp(p, "all"))
> > > > +                       xen_emul_unplug |= XEN_UNPLUG_ALL;
> > > 
> > > strncmp..
> > > 
> > 
> > is it really needed considering that we know that both strings are NULL
> > terminated and one of them is a constant?
> 
> Please do.
> 

all right


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel