Re: [Xen-devel] [PATCH] libxc: Fix Segmentation fault of xend

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Yu Zhiguo writes ("[Xen-devel] [PATCH] libxc: Fix Segmentation fault of xend"):
> If /proc/xen/privcmd cannot be opened,
> start xend occurs Segmentation fault.
> Add check to fix it.

This change is not correct.

>  void xc_clear_last_error(xc_interface *xch)
...
> -    xch->last_error.message[0] = '\0';
> +    if (xch) {

It is wrong to call xc_clear_last_error with a NULL xc_interface*.
If xend is doing this it is probably a bug in the python xc lowlevel
interface.  Can you get a stack trace please so that we can fix the
call site ?

Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel