[PATCH] Re: [Xen-devel] Re: paging_domctl() missing break statements?

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 17:27 +0100 on 23 Jun (1277314052), Patrick Colp wrote:
> The problem with the patch is that with the break statements in the
> "else" cases of XEN_DOMCTL_SHADOW_OP_ENABLE and
> XEN_DOMCTL_SHADOW_OP_OFF it currently falls through. Simply sticking
> break in at the bottom changes these control flow paths.

Yep - and that would be the right thing to do; the problem is that it
unmasked a different bug that had crept into the shadow-disable code. 
Since this bug was harmless, the other bug was a hypervisor crash, and
the release was imminent, we just reverted to the old code. 

The attached patch reinstates the breaks in the flow control (and folds
two identical cases together) and fixes the memory leak that was causing
the crash.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Attachment: shadow-disable
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel