[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86 cpu: use rdmsrl/wrmsrl



On 29/06/2010 09:37, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Hi!
> 
> Attached patch makes x86 cpu code use rdmsrl/wrmsrl and cleans up surrounding
> code.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Half of these changes are definitely for the worse. Taking arguments that
are naturally split into two halves and then assembling them by hand just to
have them split again by wrmsrl does not make the code better. Touching
generally untested code like transmeta.c also just seems a bad idea.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.