Re: [Xen-devel] [PATCH 0/1] backport libxl from xen-unstable to xen-4.0-testing

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Wed, 2010-07-07 at 17:24 +0100, Gianni Tedesco wrote:
> On Wed, 2010-07-07 at 16:58 +0100, Ian Jackson wrote:
> > Gianni Tedesco writes ("[Xen-devel] [PATCH 0/1] backport libxl from 
> > xen-unstable to xen-4.0-testing"):
> > > Following patch does what it says on the tin. It's a straightforward
> > > backport of libxl to xen-4.0-testing. This buys harmony of functionality
> > > between the two trees with the minimal of disruption to anything outside
> > > tools/libxl.
> > 
> > With this patch xl create doesn't work any more in 4.0-testing:
> 
> Wow, I find it BIZARRE that I didn't test that?! I was playing with this
> for several days. Anyway several other commands appear to have broken
> too due to incorrect getopt setup. I think this is the correct fix.
> 
> diff -r 681dce2f9cb8 tools/libxl/xl.c
> --- a/tools/libxl/xl.c        Tue Jul 06 16:00:40 2010 +0100
> +++ b/tools/libxl/xl.c        Wed Jul 07 17:22:40 2010 +0100
> @@ -65,6 +65,8 @@
>  
>      srand(time(0));
>  
> +    optind = 2;
> +
>      cspec = cmdtable_lookup(argv[1]);
>      if (cspec)
>          return cspec->cmd_impl(argc, argv);
> 

Oops, also:

diff -r a381819b54e7 tools/libxl/xl.c
--- a/tools/libxl/xl.c  Wed Jul 07 17:46:16 2010 +0100
+++ b/tools/libxl/xl.c  Wed Jul 07 17:48:52 2010 +0100
@@ -71,7 +71,7 @@
     if (cspec)
         return cspec->cmd_impl(argc, argv);
     else if (!strcmp(argv[1], "help")) {
-        help(argv[optind]);
+        help(argv[1]);
         exit(0);
     } else {
         fprintf(stderr, "command not implemented\n");




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel