[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records

To: "Tim Deegan" <Tim.Deegan@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 09 Jul 2010 15:44:20 +0100
Cc:
Delivery-date: Fri, 09 Jul 2010 07:47:43 -0700
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

>>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>+        if ( tr.extra_bytes > 28 || tr.event >= 0x1000 )

Couldn't you use TRACE_EXTRA_MAX * sizeof(u32) instead of the
literal 28?

The literal 0x1000 also doesn't look nice - I'm no sure though
whether this really is (1 << TRC_SUBCLS_SHIFT).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
  - From: Tim Deegan

References:
- [Xen-devel] [PATCH 0 of 2] New HVMOPs for PV-on-HVM drivers
  - From: Tim Deegan
- [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
  - From: Tim Deegan

Prev by Date: [Xen-API] RE: [Xen-devel] XCP Community Call #2 / confcall audio problems
Next by Date: Re: [Xen-devel] [PATCH 0/3] libxl stubdom API cleanup
Previous by thread: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
Next by thread: Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.