[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Re: [PATCH] Add a new p2m type for broken memory
On 14/07/2010 08:39, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote: > diff -r 29f0479830cd xen/include/asm-x86/page.h > --- a/xen/include/asm-x86/page.h Mon Jul 12 13:12:31 2010 +0800 > +++ b/xen/include/asm-x86/page.h Mon Jul 12 13:56:21 2010 +0800 > @@ -323,6 +323,7 @@ void setup_idle_pagetable(void); > #define _PAGE_PSE_PAT 0x1000U > #define _PAGE_PAGED 0x2000U > #define _PAGE_SHARED 0x4000U > +#define _PAGE_BROKEN 0x8000U I don't see this used anywhere. Also, not that you started it, but it doesn't seem nice to add extra _PAGE_* definitions in page.h for flags which never (afaict) actually appear in any pte. At least the extra return-code-only flags should be separated off and commented. Having the macros not start with _PAGE_ might be a good idea too. Of course all this is ultimately to be acked/nacked by Tim. -- Keir > /* > * Debug option: Ensure that granted mappings are not implicitly unmapped. > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |