Re: [Xen-devel] [PATCH] HVM Debug Console Support

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 14:51 +0100 on 19 Jul (1279551066), Owen Smith wrote:
> diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c
> --- a/tools/libxc/xc_domain_save.c
> +++ b/tools/libxc/xc_domain_save.c
> @@ -915,7 +915,7 @@
>      uint8_t *hvm_buf = NULL;
>  
>      /* HVM: magic frames for ioreqs and xenstore comms. */
> -    uint64_t magic_pfns[3]; /* ioreq_pfn, bufioreq_pfn, store_pfn */
> +    uint64_t magic_pfns[4]; /* ioreq_pfn, bufioreq_pfn, store_pfn, 
> console_pfn */

This breaks save-file compatibility with older tools.  Look at how
HVM_PARAM_IDENT_PT and HVM_PARAM_VM86_TSS are handled for a better model
of how to add your new param to the save format.

Cheers,

Tim

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel