Re: [Xen-devel] [PATCH]: fix segfault in xl destroy when xenstore has been fowled up

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 20 Jul 2010, Gianni Tedesco (3P) wrote:
> Oops, forgot signed off by and change subject
> 
> 8<---------------------
> Fix segfault in xl destroy when xenstore has been fowled up
> 
> libxl_dirname() returns NULL if a string is passed to it which doesn't
> look like a xenstore key. During xl destroy libxl_dirname is used to
> generate an xs path in order to remove device backend keys. If a
> nonsense key has been put in there resulting in NULL backend path this
> will crash xl.
> 
> Signed-off-by: <gianni.tedesco@xxxxxxxxxx>
> 
> diff -r 1eea12f66951 tools/libxl/libxl_device.c
> --- a/tools/libxl/libxl_device.c      Tue Jul 20 17:14:43 2010 +0100
> +++ b/tools/libxl/libxl_device.c      Tue Jul 20 18:05:19 2010 +0100
> @@ -344,7 +344,8 @@ int libxl_devices_destroy(struct libxl_c
>      }
>      for (i = 0; i < n; i++) {
>          flexarray_get(toremove, i, (void**) &path);
> -        xs_rm(clone.xsh, XBT_NULL, path);
> +        if ( path )
> +            xs_rm(clone.xsh, XBT_NULL, path);
>      }
>      flexarray_free(toremove);
>      libxl_ctx_free(&clone);
> 
 
I prefer the other approach.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel