Re: [Xen-devel] [PATCH] tools: gpxe build fix

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 21/07/2010 16:41, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> Christoph Egger writes ("[Xen-devel] [PATCH] tools: gpxe build fix"):
>> On NetBSD, uname -m prints 'amd64'.
>> Attached patch makes gpxe aware of that.
> 
> Are there any other systems on which uname -m prints amd64 on which
> this patch will break ?
> 
> I think calling a patch "Makefile.patch" is going to be annoying.
> And patches in a series should not be named just after the file they
> change as if only one patch touches each file.
> 
> How about "makefile-amd64.patch" ?
> 
> Also "gpxe build fix" is a hopeless commit message.

I ended up upgrading us to far more recent gpxe, where this whole issue has
simply disappeared.

 -- Keir

> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel