Re: [Xen-devel] [PATCH 2 of 9] libxl: return libxl_dominfo from libxl_event_get_domain_death_info

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2010-07-26 at 16:26 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 2 of 9] libxl: return libxl_dominfo 
> from libxl_event_get_domain_death_info"):
> > libxl: return libxl_dominfo from libxl_event_get_domain_death_info
> > Removes a libxc data type from the libxl interface.
> 
> I don't think this is the right approach, mainly because shutdown
> reasons aren't a libxc datatype, but a Xen one.  My view is that libxl
> should hide libxc, but that it is allowed to expose Xen.
> 
> So libxl callers are allowed to #include xen/include/public/sched.h.

I'm happy with exposing Xen datatypes if that is the approach we want to
take but not with returning an xc_domaininfo_t.

I think the right compromise is therefore to declare that
libxl_dominfo.shutdown_reason contains the values defined in
xen/.../sched.h rather than a new libxl enum and retain the switch to
returning libxl_dominfo.

(Maybe that's what you meant anyhow)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel