[Xen-devel] Re: [PATCH]: xl, fix segfault when detaching non-existant disk

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Tue, 2010-07-27 at 16:21 +0100, Ian Jackson wrote:
> Gianni Tedesco (3P) writes ("[PATCH]: xl, fix segfault when detaching 
> non-existant disk"):
> >      val = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/backend-id", 
> > diskpath));
> > +    if (!val)
> > +        return ERROR_FAIL;
> 
> This is fine as far as it goes, and I'll apply it, but would you like
> to do the same for all the other unchecked libxl_xs_read calls ? :-)

It's a gigantic piece of work, along with sorting out various memory
leaks. It is on my TODO list :)

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel