[Xen-devel] Re: [PATCH 3 of 3] Centralize parsing of PCI BDF's in xl

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 28 Jul 2010, Gianni Tedesco (3P) wrote:
>  tools/libxl/libxl.h      |   6 +---
>  tools/libxl/libxl_pci.c  |  71 
> +++++++++++++++++++++++++++++++++++++----------
>  tools/libxl/xl_cmdimpl.c |  46 ++++--------------------------
>  3 files changed, 64 insertions(+), 59 deletions(-)
> 
> 
> Introduce a new libxl call libxl_device_pci_parse_bdf() and use it
> consistently.
> 
> This patch also fixes an infinite loop bug in xl create. If there is a
> parse-error on any pci config file entry then xl will attempt to skip it, but
> since num_pcidevs is used to index the config list and is not incremented when
> skipping, this caused an infinite loop. Solve that problem by introducing a 
> new
> loop counter variable.
> 
> Note that virtual PCI slots are not parsed by the new code. However this is
> a step towards support for virtual slots and multi-function device assignment
> since only one location in the code will need to be changed now.
> 
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> 


Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel