Re: [Xen-devel] Re: [PATCH] libxl: move blktap-specific code into libxl_blktap.c

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Friday 30 July 2010 10:40:27 Christoph Egger wrote:
> On Thursday 29 July 2010 20:02:09 Ian Jackson wrote:
> > Christoph Egger writes ("[PATCH] libxl: move blktap-specific code into
>
> libxl_blktap.c"):
> > > libxl: move blktap-specific code into libxl_blktap.c
> >
> > Except, once again, this is not _pure_ motion.  You need to split the
> > patch up so that, in the code motion patch,
> >
> >   diff -u <(hg diff tools/libxl/libxl.c | perl -pe 's/^[-+]/ $& eq "-" ?
> > "+" : "-" /e' ) <(hg diff tools/libxl/libxl_blktap.c)
> >
> > doesn't produce any substantive output.
>
> I'm sorry, I don't know perl. And this command fails with syntax error: '('
> unexpected.
>
> I haven't send the patch yesterday.

Wanted to say: I haven't send the patch with the change yesterday.

> It was late for me. 
> You seem to respond always in the late afternoon (CEST).
> In which timezone are you ?
>
> Christoph



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel