Re: [Xen-devel] [PATCH 5 of 8] libxl: autogenerate _libxl_types.h

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Tue, 2010-08-03 at 13:29 +0100, Ian Campbell wrote:
> On Tue, 2010-08-03 at 13:13 +0100, Gianni Tedesco (3P) wrote:
> > On Tue, 2010-08-03 at 12:00 +0100, Ian Campbell wrote:
> > > +Types = [
> > > +    libxl_dominfo,
> > > +    libxl_poolinfo,
> > > +    libxl_vminfo,
> > > +    libxl_version_info,
> > > +    libxl_domain_create_info,
> > > +    libxl_file_reference,
> > > +    libxl_domain_build_info,
> > > +    libxl_domain_build_state,
> > > +    libxl_device_model_info,
> > > +    libxl_device_vfb,
> > > +    libxl_device_vkb,
> > > +    libxl_device_console,
> > > +    libxl_device_disk,
> > > +    libxl_device_nic,
> > > +    libxl_device_net2,
> > > +    libxl_device_pci,
> > > +]
> > 
> > I like the idea of the patch, I think the libxl bits should be in a
> > separate python module though or perhaps the gentypes.py.
> 
> I agree, and said as much in my intro mail ;-)

Ah I did read it but must've slipped my memory during tinkering with the
patches :)

> > Also I think an integer ptr attribute on the base class would be a good
> > idea if only to get rid of nasty whitespace issue :) -- I haven't groked
> > the code too closely but it may also be able to fold such a thing in to
> > has_destructor attribute? anyway...
> 
> Ideally the autogenerator wouldn't concern itself with
> indentation/whitespace/etc at all and would simply pipe its output
> through a suitably formed invocation of lindent. I just hand coded it
> for now to match something usable if not ideal (and to be comparable to
> the before state).

Fair enough.

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel