Re: [Xen-devel] [PATCH 02/14] Nested Virtualization: localevent

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 06/08/2010 10:17, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> For this reason, nestedhvm_vcpu_destroy() (added in patch 5/14)
> does a nestedsvm_vcpu_stgi() to prevent the interrupts/events
> from being blocked by hvm_interrupt_blocked() (see patch 9/14)
> and level 1 guest remaining in a zombie state.

Ah, this is the crux of it. You shouldn't need to stgi from the vcpu
destructor. It makes no sense and doing it shouldn't leave you with a zombie
domain. Indeed, vcpu_destroy() is called from the very final domain
destructor -- vcpu_destroy's caller finishes by freeing the domain structure
itself, so not much chance of hanging around as a zombie! I'm assuming you
call nestedhvm_vcpu_destroy() on the vcpu_destroy() path here by the way...
If it's called from some other context then I think its name is misleading
and should be changed.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel