Re: [Xen-devel] [PATCH 05/14] Nested Virtualization: core

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

Hi, 

> +int
> +nestedhvm_vcpu_destroy(struct vcpu *v)
> +{
> +     int ret = 0;
> +
> +     if (!nestedhvm_enabled(v->domain))
> +             return 0;
> +
> +     if (nestedhvm_vcpu_in_guestmode(v)) {
> +             nestedhvm_vcpu_exit_guestmode(v);
> +             ret = -EBUSY;
> +     }

This still bothers me, since we go on to complete the teardown anyway,
and this function's only caller does nothing interesting with the
result.

> +     /* Enable interrupts or the guest won't see any interrupts
> +      * after nested guest exited.
> +      */
> +     nestedsvm_vcpu_stgi(v);
> +
> +     hvm_nestedhvm_vcpu_destroy(v);

While I'm complaining about unchecked return values, I should point out
that your implementation of this returns an integer (which in turn is
always 0).

> +     return ret;
> +}

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel