[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] msi: Avoid uninitialized msi descriptors



On 11/08/2010 18:09, "Dante Cinco" <dantecinco@xxxxxxxxx> wrote:

> I'm glad that somebody who is familiar with MSI has resolved this
> problem although I haven't applied and verified the proposed patch yet
> on my system. I posted the Xen crash I experienced related to this
> issue on xen-devel a couple of weeks ago (see link below) but wasn't
> familiar enough with the MSI/MSI-X code to propose a solution other
> than to back out changelist 21778.

Let me know when you confirm. I backported 21778 for 4.0.1, perhaps in too
much haste. If this is a good fix then I should backport it as well.

 Thanks,
 Keir

> http://old.nabble.com/Re:-(XEN)-RIP:-e008:-%3Cffff82c48015564b%3E---write_msi_
> msg%2B0x2b-0x150-p29301832.html
> 
> Dante
> 
> 
> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Wei Wang2
> Sent: Wednesday, August 11, 2010 6:43 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-devel] [PATCH] msi: Avoid uninitialized msi descriptors
> 
> Hi,
> When __pci_enable_msix() returns early, output parameter (struct msi_desc
> **desc) will not be initialized.  On my machine, a Broadcom BCM5709
> nic has both MSI and MSIX capability blocks and when guest tries to
> enable msix interrupts but __pci_enable_msix() returns early for
> encountering a msi block,  the whole system will crash for fatal page
> fault immediately.
> 
> Thanks,
> Wei
> 
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> --
> AMD GmbH, Germany
> Operating System Research Center
> 
> Legal Information:
> Advanced Micro Devices GmbH
> Karl-Hammerschmidt-Str. 34
> 85609 Dornach b. München
> 
> Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
> Sitz: Dornach, Gemeinde Aschheim, Landkreis München Registergericht
> München, HRB Nr. 43632
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.